[18.0][MIG] hr_expense_employee_analytic_default: Migration to 18.0 #283
[18.0][MIG] hr_expense_employee_analytic_default: Migration to 18.0 #283BhaveshHeliconia wants to merge 6 commits intoOCA:18.0from
Conversation
|
/ocabot migration hr_expense_employee_analytic_default |
BhaveshHeliconia
force-pushed
the
18.0-mig-hr_expense_employee_analytic_default
branch
from
bd6b65c to
d435580
Compare
BhaveshHeliconia
force-pushed
the
18.0-mig-hr_expense_employee_analytic_default
branch
from
d435580 to
4c8d228
Compare
There was a problem hiding this comment.
Code LGTM.
- When changing the employee, the analytical distribution will
be updated.
When changing to a product, where no analytic distribution exists, the analytic accounts are not removed but stay with the previous distribution.
I've also tried to set a distribution for Partner "Anita Oliver", but when I select the employee "Anita Oliver" the distribution is not applied.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
BhaveshHeliconia
force-pushed
the
18.0-mig-hr_expense_employee_analytic_default
branch
from
4c8d228 to
ca077a2
Compare
|
@BhaveshHeliconia same findings like before. Did you change anything or just a rebase? |
BhaveshHeliconia
force-pushed
the
18.0-mig-hr_expense_employee_analytic_default
branch
from
ca077a2 to
8419086
Compare
|
@CRogos : Earlier I had only rebased, but now I’ve also updated the README file. |
|
I agree with the readme change, but changing the employee did not work, and also the analytic distribution did not get removed, when I change to a product without distribution template. |
Okay, I’ll work on fixing that. |
github-actions
bot
removed
the
stale
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
TT47803 [UPD] Update hr_expense_employee_analytic_default.pot
Currently translated at 100.0% (2 of 2 strings) Translation: hr-expense-17.0/hr-expense-17.0-hr_expense_employee_analytic_default Translate-URL: https://translation.odoo-community.org/projects/hr-expense-17-0/hr-expense-17-0-hr_expense_employee_analytic_default/it/
BhaveshHeliconia
force-pushed
the
18.0-mig-hr_expense_employee_analytic_default
branch
from
8419086 to
e070f35
Compare
github-actions
bot
removed
the
stale
BhaveshHeliconia
force-pushed
the
18.0-mig-hr_expense_employee_analytic_default
branch
from
e070f35 to
93b161b
Compare
|
@CRogos : The module now updates and clears the analytic distribution as expected when changing the employee or product, both interactively and on save. I have also added test cases for the onchange logic. |
|
This PR has the |
CRogos
left a comment
CRogos
left a comment
There was a problem hiding this comment.
@BhaveshHeliconia we are currently not using this module. Therefore I am not really into it and my first test failed, most likely because I did not set the work_contact_id correct.
8 participants
No description provided.